On Tue, Feb 10, 2004 at 05:15:39PM +0100, Maciej W. Rozycki wrote: > Ralf, > > Gcc 3.4 complains about a possibly undefined operation in dump16() in > arch/mips/lib/r3k_dump_tlb.c. The following patch fixes it. I've taken > the opportunity to clean up the file and its counterparts thus: > > 1. I've cast the pointers to "unsigned long" consistently for output > formatting as the width specifier doesn't work very well with pointers. > > 2. I've renamed msg2str() to msk2str() in one of the variations. > > 3. I've reordered header inclusions in one of the variations. > > 4. I've fixed indentation throughout, perhaps not completely, but still > the result should be somewhat closer to sanity. > > These changes make the three variations closer to one another where > possible. > > OK to apply? Sure, go ahead. I guess the output format could also use some improvments for readability ... Ralf
