On Sat, Jan 17, 2004 at 01:51:42PM +0100, Jan-Benedict Glaw wrote: > On Sat, 2004-01-17 13:20:22 +0100, Ralf Baechle <ralf@linux-mips.org> > wrote in message <20040117122022.GD5288@linux-mips.org>: > > #define FOO_BASE 0x12340000UL /* physical address */ > ^^^^^^^^^^ > > #define FOO_SIZE 0x00001000UL > > > > base = ioremap(0x1234, FOO_SIZE); > ^^^^^^ > Not FOO_BASE? > And it's better to use writel/readl and friends on thingies returned by ioremap: struct foo_regs* foo = ioremap(FOO_BASE, FOO_SIZE); ... writel(42, &foo->blinkenlight); Dimitri -- Dimitri Torfs | NSCE dimitri@sonycom.com | The Corporate Village tel: +32 2 7008541 | Da Vincilaan 7 - D1 fax: +32 2 7008622 | B-1935 Zaventem - Belgium
