Sorry for the typo in the transcription, the source code is correct regarding the test and assignment. > -----Original Message----- > From: linux-mips-bounce@linux-mips.org > [mailto:linux-mips-bounce@linux-mips.org]On Behalf Of Jan-Benedict Glaw > Sent: Thursday, November 13, 2003 12:59 AM > To: Linux-MIPS > Subject: Re: Patch for ALI15x3 - Linux-MIPS kernel 2.4.22-rc3 > > > On Wed, 2003-11-12 17:13:53 -0800, Jack Miller > <jack.miller@pioneer-pdt.com> > wrote in message > <JCELLCFDJLFKPOBFKGFNEENFCHAA.jack.miller@pioneer-pdt.com>: > > Alan, > > I am not so sure of that. If you look at > ide-disk.c:__ide_do_rw_disk(), > > there is a local variable assignment statement: > > > > u8 lba48 = (drive->addressing = 1) ? 1 : 0; > ^^^ > > Explode. Now, lba48 would _always_ be 1. > > MfG, JBG > > -- > Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 > "Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | > Gegen Krieg > fuer einen Freien Staat voll Freier Bürger" | im Internet! | > im Irak! > ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | > DRM | TCPA)); >
