Re: ddb5477 fixes for 2.6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 18 Sep 2003, Daniel Jacobowitz wrote:

> >  Is it OK for other PCI systems?
> 
> Yes, I think so.  Those two functions seem to have migrated in from
> pci-hplj.c; they can't possibly compile, since they use constants only
> defined in that file.

 Then the snippet should probably get removed altogether.

> >  Why do you want these suffixes?  They don't work for assembly sources.
> 
> Because otherwise uses of XKPHYS in a 32-bit kernel generate noisy
> warnings.  I don't remember where it was offhand.  Wrap it in
> __ASSEMBLY__ if you like.

 Hmm, but is there any use for XKPHYS, etc. in a 32-bit kernel at all? 
The address cannot effectively be used anyway. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux