>>>>> "ladis" == Ladislav Michl <ladis@linux-mips.org> writes:
ladis> read eaddr using NVRAM access fuctions and make various cleanups so driver
ladis> can be build as module
You are my hero!
[ Removal of Space.c entry ]
Hero++
ladis> @@ -96,8 +97,8 @@
ladis> struct sgiseeq_private {
ladis> volatile struct sgiseeq_init_block srings;
ladis> char *name;
ladis> - volatile struct hpc3_ethregs *hregs;
ladis> - volatile struct sgiseeq_regs *sregs;
ladis> + struct hpc3_ethregs *hregs;
ladis> + struct sgiseeq_regs *sregs;
I read through all the patch, and I didn't understand why volatile is
not needed anymore :(
Althought not that I did understand why it was needed in the first
place :)
ladis> @@ -435,7 +439,7 @@
ladis> /* Always check for received packets. */
ladis> sgiseeq_rx(dev, sp, hregs, sregs);
ladis> - /* Only check for tx acks iff we have something queued. */
ladis> + /* Only check for tx acks if we have something queued. */
ladis> if (sp->tx_old != sp->tx_new)
ladis> sgiseeq_tx(dev, sp, hregs, sregs);
iff == Math speak for if and only if. Not sure if iff is needed in
that context at all.
Later, Juan.
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
