On Tue, 2003-04-22 at 15:56, Jun Sun wrote: > I think this is a good example to show benefit of code sharing. > There is no good reason for au1x00 boards of not using new time.c. > You get to write less board code, fewer bugs and future proof. The I didn't use the generic time.c back then is power management. The CP0 counter sleeps when using the 'wait' instruction, so in that case you have to use a different counter with a rather poor resolution. The modifications I had to make were such that they couldn't go in the generic time.c. But that area definitely needs to be revisited and cleaned up. Pete > Jun > > On Tue, Apr 22, 2003 at 12:54:50PM -0700, Jeff Baitis wrote: > > Pete: > > > > While struggling to get Linux up on Evolution's custom board based on the > > Au1500, I discovered a poorly handled case in time.c; null interrupts are > > handled should not affect the local IRQ count. (if the local IRQ count is not > > decremented, tests for in_irq() fail.) > > > > Thanks for taking a look at my patch! > > > > -Jeff > > > > Index: time.c > > =================================================================== > > RCS file: /home/cvs/linux/arch/mips/au1000/common/time.c,v > > retrieving revision 1.5.2.10 > > diff -u -r1.5.2.10 time.c > > --- time.c 25 Mar 2003 14:30:19 -0000 1.5.2.10 > > +++ time.c 22 Apr 2003 19:47:24 -0000 > > @@ -114,6 +114,7 @@ > > return; > > > > null: > > + irq_exit(cpu, irq); > > ack_r4ktimer(0); > > } > > > > > >
