On Tue, 22 Apr 2003, Ralf Baechle wrote:
> On Tue, Apr 22, 2003 at 01:17:21PM +0200, Juan Quintela wrote:
> > yoichi> +static struct resource vr41xx_pci_mem_resource = {
> > yoichi> + "PCI memory space",
> > yoichi> + VR41XX_PCI_MEM_START,
> > yoichi> + VR41XX_PCI_MEM_END,
> > yoichi> + IORESOURCE_MEM
> > yoichi> +};
> >
> > Please, use C99 named initializers in the whole file.
>
> I don't think there's much point in using ISO style initializers everywhere.
> So far the convention is only to replace the GNU-style inializer.
> We unfortunately have a few places where the code got inflated by at least
> the factor of 3 because now some code uses the ISO initializers for
> everything - for no good reason.
What if someone will change struct resource in the future?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
