Jun Sun wrote: > > This patch make the following changes > > 1) CONFIG_REMOTE_DEBUG -> CONFIG_KGDB > 2) CONFIG_DEBUG -> CONFIG_RUNTIME_DEBUG > > MIPS is pretty much the only one (other than the pitiful s390 :0) > using REMOTE_DEBUG instead of KGDB. So it is a good thing to change > it. > > As Keith pointed out, CONFIG_DEBUG is too general (which has > already caused confusion, BTW). RUNTIME_DEBUG is more appropriate. I'd like to propose a further change here, which is to decouple the inclusion of debugging symbols from building with KGDB support. I use a JTAG debugger all the time, and don't need/want KGDB built in (by default it forces the remote GDB to attach and continue, and it steals one of the serial ports on my platform). How about adding "CONFIG_DEBUG_INFO" which simply adds '-g' to the CFLAGS? REMOTE_KGDB can be left independent of this option by allowing either option to enable '-g'. Patch for 2.4 attached. Comments? Kip
Index: arch/mips/config-shared.in =================================================================== RCS file: /home/cvs/linux/arch/mips/Attic/config-shared.in,v retrieving revision 1.1.2.48 diff -u -r1.1.2.48 config-shared.in --- arch/mips/config-shared.in 26 Feb 2003 21:14:23 -0000 1.1.2.48 +++ arch/mips/config-shared.in 3 Mar 2003 19:41:11 -0000 @@ -976,6 +976,7 @@ bool 'Are you using a crosscompiler' CONFIG_CROSSCOMPILE bool 'Enable run-time debugging' CONFIG_RUNTIME_DEBUG +bool 'Debugging symbols' CONFIG_DEBUG_INFO bool 'Remote GDB kernel debugging' CONFIG_KGDB dep_bool ' Console output to GDB' CONFIG_GDB_CONSOLE $CONFIG_KGDB if [ "$CONFIG_SIBYTE_SB1xxx_SOC" = "y" ]; then Index: arch/mips/Makefile =================================================================== RCS file: /home/cvs/linux/arch/mips/Makefile,v retrieving revision 1.78.2.23 diff -u -r1.78.2.23 Makefile --- arch/mips/Makefile 26 Feb 2003 21:14:23 -0000 1.78.2.23 +++ arch/mips/Makefile 3 Mar 2003 19:41:11 -0000 @@ -41,8 +41,8 @@ LINKFLAGS += -G 0 -static # -N MODFLAGS += -mlong-calls -ifdef CONFIG_KGDB -GCCFLAGS += -g +ifneq ($(CONFIG_DEBUG_INFO)$(CONFIG_KGDB),) +GCCFLAGS += -gstabs+ ifdef CONFIG_SB1XXX_CORELIS GCCFLAGS += -mno-sched-prolog -fno-omit-frame-pointer endif Index: arch/mips64/Makefile =================================================================== RCS file: /home/cvs/linux/arch/mips64/Makefile,v retrieving revision 1.22.2.27 diff -u -r1.22.2.27 Makefile --- arch/mips64/Makefile 26 Feb 2003 21:14:24 -0000 1.22.2.27 +++ arch/mips64/Makefile 3 Mar 2003 19:41:11 -0000 @@ -39,7 +39,7 @@ LINKFLAGS += -G 0 -static # -N MODFLAGS += -mlong-calls -ifdef CONFIG_KGDB +ifneq ($(CONFIG_DEBUG_INFO)$(CONFIG_KGDB),) GCCFLAGS += -g ifdef CONFIG_SB1XXX_CORELIS GCCFLAGS += -mno-sched-prolog -fno-omit-frame-pointer
