Hi
I found at least two things that look like bugs in the
handling of the caches for r4k:
- call flush_cache_l1() when the size is bigger that the secondary
cache, should be flush_cache_all().
- call flush_dcache_line/flush_scache_line() when the user asked for
invalidation (i.e. not need for writeback).
Comments?
Later, Juan.
Index: arch/mips64/mm/c-r4k.c
===================================================================
RCS file: /home/cvs/linux/arch/mips64/mm/c-r4k.c,v
retrieving revision 1.1.2.10
diff -u -r1.1.2.10 c-r4k.c
--- arch/mips64/mm/c-r4k.c 20 Dec 2002 03:08:32 -0000 1.1.2.10
+++ arch/mips64/mm/c-r4k.c 20 Dec 2002 19:10:45 -0000
@@ -979,7 +979,7 @@
unsigned long end, a;
if (size >= scache_size) {
- flush_cache_l1();
+ flush_cache_all();
return;
}
@@ -1010,7 +1010,7 @@
a = addr & ~(dc_lsize - 1);
end = (addr + size - 1) & ~(dc_lsize - 1);
while (1) {
- flush_dcache_line(a); /* Hit_Writeback_Inv_D */
+ invalidate_dcache_line(a); /* Hit_Invalidate_D */
if (a == end) break;
a += dc_lsize;
}
@@ -1027,14 +1027,14 @@
unsigned long end, a;
if (size >= scache_size) {
- flush_cache_l1();
+ flush_cache_all();
return;
}
a = addr & ~(sc_lsize - 1);
end = (addr + size - 1) & ~(sc_lsize - 1);
while (1) {
- flush_scache_line(a); /* Hit_Writeback_Inv_SD */
+ invalidate_scache_line(a); /* Hit_Invalidate_SD */
if (a == end) break;
a += sc_lsize;
}
--
In theory, practice and theory are the same, but in practice they
are different -- Larry McVoy
