On 18 Dec 2002, Juan Quintela wrote:
> maciej> Is it needed? The part that returns .mx should be optimized away by the
> maciej> compiler automagically if unused.
>
> Idea was to make things compile without warnings, that way when you
> change anything, you search for warnings :(
The idea is fine, sure.
> With the changes that I sent, I have put the warnings levels down to
> (for IP22) to:
> - 7 C warnings
> - 2 Asm warnings
A few warnings are unavoidable -- e.g. there is no way to shut up gas
complaining about macros expanding into multiple instructions in branch
delay slots. Too bad.
How about this patch? -- it seems to work here (gcc 2.95.4).
--
+ Maciej W. Rozycki, Technical University of Gdansk, Poland +
+--------------------------------------------------------------+
+ e-mail: macro@ds2.pg.gda.pl, PGP key available +
patch-mips-2.4.20-pre6-20021212-setcx-0
diff -up --recursive --new-file linux-mips-2.4.20-pre6-20021212.macro/arch/mips/math-emu/ieee754int.h linux-mips-2.4.20-pre6-20021212/arch/mips/math-emu/ieee754int.h
--- linux-mips-2.4.20-pre6-20021212.macro/arch/mips/math-emu/ieee754int.h 2002-12-16 17:17:55.000000000 +0000
+++ linux-mips-2.4.20-pre6-20021212/arch/mips/math-emu/ieee754int.h 2002-12-18 18:31:51.000000000 +0000
@@ -58,10 +58,10 @@
#define CLPAIR(x,y) ((x)*6+(y))
#define CLEARCX \
- (ieee754_csr.cx = 0)
+ (ieee754_csr.cx = 0)
#define SETCX(x) \
- (ieee754_csr.cx |= (x),ieee754_csr.sx |= (x),ieee754_csr.mx & (x))
+ ({ieee754_csr.cx |= (x); ieee754_csr.sx |= (x); ieee754_csr.mx & (x);})
#define TSTX() \
(ieee754_csr.cx & ieee754_csr.mx)
