ELF32 problem in mips64 kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There is a faulty check in include/asm-mips64/elf.h:

in elf_check_arch, the following access to the "e_flags" field is
non-sensical if the binary is ELFCLASS32, because "__h" is typed as an
elf64_hdr (through the elfhdr #define), whose e_flags is in a different
location from an elf32_hdr.

        if ((__h->e_ident[EI_CLASS] == ELFCLASS32) &&     \
            ((__h->e_flags & EF_MIPS_ABI2) == 0))         \
                __res = 0;                                \

Should the n32 check (is this what the EF_MIPS_ABI2 check is about?) be
punted to another binary format handler?  The attached patch removed the
ABI2 check.

Kip
Index: include/asm-mips64/elf.h
===================================================================
RCS file: /cvs/linux/include/asm-mips64/elf.h,v
retrieving revision 1.10.2.2
diff -u -r1.10.2.2 elf.h
--- include/asm-mips64/elf.h	2002/08/20 18:42:37	1.10.2.2
+++ include/asm-mips64/elf.h	2002/09/18 21:19:42
@@ -43,8 +43,7 @@
 									\
 	if (__h->e_machine != EM_MIPS)					\
 		__res = 0;						\
-	if ((__h->e_ident[EI_CLASS] == ELFCLASS32) &&			\
-	    ((__h->e_flags & EF_MIPS_ABI2) == 0))			\
+	if (__h->e_ident[EI_CLASS] == ELFCLASS32) 			\
 		__res = 0;						\
 									\
 	__res;								\
@@ -53,7 +52,8 @@
 /*
  * These are used to set parameters in the core dumps.
  */
-#define ELF_CLASS	ELFCLASS64
+//#define ELF_CLASS	ELFCLASS64
+#define ELF_CLASS	ELFCLASS32
 #ifdef __MIPSEB__
 #define ELF_DATA	ELFDATA2MSB
 #elif __MIPSEL__

[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux