Just more clean ups. I tested it, it works. -Steve diff -urN -X cvs-exc.txt mipslinux-2.4.17-xfs/arch/mips/kernel/gdb-stub.c settop/arch/mips/kernel/gdb-stub.c --- mipslinux-2.4.17-xfs/arch/mips/kernel/gdb-stub.c Thu Nov 29 09:13:08 2001 +++ settop/arch/mips/kernel/gdb-stub.c Fri Feb 8 09:14:52 2002 @@ -306,7 +306,7 @@ unsigned char ch; while (count-- > 0) { - if (kgdb_read_byte(mem++, &ch) != 0) + if (kgdb_read_byte((unsigned *) mem++, (unsigned *) &ch) != 0) return 0; *buf++ = hexchars[ch >> 4]; *buf++ = hexchars[ch & 0xf]; @@ -332,7 +332,7 @@ { ch = hex(*buf++) << 4; ch |= hex(*buf++); - if (kgdb_write_byte(ch, mem++) != 0) + if (kgdb_write_byte((unsigned) ch, (unsigned *) mem++) != 0) return 0; } @@ -902,23 +902,21 @@ if (!initialized) return; - __asm__ __volatile__(" - .globl breakinst - .set noreorder - nop -breakinst: break - nop - .set reorder - "); + __asm__ __volatile__( + ".globl\tbreakinst\n\t" + ".set\tnoreorder\n\t" + "nop\n\t" + "breakinst:\tbreak\n\t" + "nop\n\t" + ".set\treorder\n\t"); } void adel(void) { - __asm__ __volatile__(" - .globl adel - la $8,0x80000001 - lw $9,0($8) - "); + __asm__ __volatile__( + ".globl\tadel\n\t" + "la\t$8,0x80000001\n\t" + "lw\t$9,0($8)\n\t"); } #ifdef CONFIG_GDB_CONSOLE