On Tue, 18 Dec 2001, Jun Sun wrote: > > So I should modify ioremap to return (addr+isa_slot_offset) when > > CONFIG_ISA is defined and the given I/O address is in the 16 MB ISA > > range. > > I would consider it only as a workaround rather than a fix. Why? > You need to make sure all other PCI-based boards have isa_slot_offset set to > 0. I don't think it's needed. Why to refer to isa_slot_offset for PCI accesses at all? > ioremap() has been used by many PCI device drivers, and on MIPS it assumes 1:1 > mapping between PCI memory space and CPU physical space. It have been working > so far either because PCI device BARs are shuffled around to match their > physical address (from CPU point of view) or dev structure is modified > propoerly with special fixups. > > Now when people using ioremap/readb/writeb method to access ISA memory space, > which lives in the lower range of the "bus memory space", it will collide with > system ram under 1:1 mapping assumption. Hmm, I believe there should be no such problem. For systems equipped with the PCI bus we may just assume the low 16MB of PCI memory address space is reserved for ISA memory addresses (it's hardwired for many platforms, so there should be no problem with it), i.e. avoid programming BARs to point to that space and make ioremap() (or __ioremap(), actually) act accordingly, i.e. assume a 1:1 mapping for addresses above 16MB and perform an ISA mapping for ones below 16MB. -- + Maciej W. Rozycki, Technical University of Gdansk, Poland + +--------------------------------------------------------------+ + e-mail: macro@ds2.pg.gda.pl, PGP key available +
