Re: PATCH: spurious_count cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



BTW, ".set noreorder" in this code seems dangerous while the jump
instruction is not followed by nop...


> --- arch/mips/kernel/entry.S	2001/11/27 01:26:46	1.32
> +++ arch/mips/kernel/entry.S	2001/11/30 18:42:07
> @@ -95,12 +95,12 @@
>  		 * Someone tried to fool us by sending an interrupt but we
>  		 * couldn't find a cause for it.
>  		 */
> -		lui     t1,%hi(spurious_count)
> +		lui     t1,%hi(irq_err_count)
>  		.set	reorder
> -		lw      t0,%lo(spurious_count)(t1)
> +		lw      t0,%lo(irq_err_count)(t1)
>  		.set	noreorder
>  		addiu   t0,1
> -		sw      t0,%lo(spurious_count)(t1)
> +		sw      t0,%lo(irq_err_count)(t1)
>  		j	ret_from_irq
>  		END(spurious_interrupt)
>  
---
Atsushi Nemoto

[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux