time_init() enables interrupt.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



arch/mips/kernel/time.c:time_init() in current CVS contains following codes:

	/* setup xtime */
	write_lock_irq(&xtime_lock);
	xtime.tv_sec = rtc_get_time();
	xtime.tv_usec = 0;
	write_unlock_irq(&xtime_lock);

The write_unlock_irq() macro calls __sti(), but it is too early to
enable interrupts.

I think this write_lock_irq/write_unlock_irq pair should be removed
(or replaced with write_lock_irqsave/write_unlock_irqrestore pair).

---
Atsushi Nemoto


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux