On Wed, Feb 28, 2001 at 01:47:27PM +0100, Maciej W. Rozycki wrote: > Date: Wed, 28 Feb 2001 13:47:27 +0100 (MET) > From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl> > To: Fabrice Bellard <bellard@email.enst.fr>, > Ralf Baechle <ralf@uni-koblenz.de> > cc: linux-mips@oss.sgi.com > Subject: Re: Serious bug in uaccess.h > > On Tue, 27 Feb 2001, Fabrice Bellard wrote: > > > I mean the code in arch/mips/lib/memcpy.S. It is possible to modify > > __copy_user so that it has exactly the same calling convention of a C > > function. Then, no asm is necessary in uaccess.h. It costs us a > > supplementary jump. > > You mean the supplementary return value in a2? Hmm, it is always set to > zero! Also "addu $1, %2, %3" makes no sense. > > Ralf, the code is weird. The header implies you are the author. Could > you please elaborate what you meant in copy_*_user()? I'll look at it and try to recall :-) Ralf
