Hello,
On Mon, 17 Apr 2023, Simon Horman wrote:
> Hi Julian,
>
> this series aims to clean up IPVS in several ways without
> implementing any functional changes, aside from removing
> some debugging output.
>
> Patch 1/4: Update width of source for ip_vs_sync_conn_options
> The operation is safe, use an annotation to describe it properly.
>
> Patch 2/4: Consistently use array_size() in ip_vs_conn_init()
> It seems better to use helpers consistently.
>
> Patch 3/4: Remove {Enter,Leave}Function
> These seem to be well past their use-by date.
>
> Patch 4/4: Correct spelling in comments
> I can't spell. But codespell helps me these days.
>
> All changes: compile tested only!
>
> ---
> Changes in v3:
> - Patch 2/4: Correct division by 1024.
> It was applied to the wrong variable in v2.
> - Add Horatiu's Reviewed-by tag.
>
> Changes in v2:
> - Patch 1/4: Correct spelling of 'conn' in subject.
> - Patch 2/4: Restore division by 1024. It was lost on v1.
>
> ---
> Simon Horman (4):
> ipvs: Update width of source for ip_vs_sync_conn_options
> ipvs: Consistently use array_size() in ip_vs_conn_init()
> ipvs: Remove {Enter,Leave}Function
> ipvs: Correct spelling in comments
The patchset looks good to me, thanks!
Acked-by: Julian Anastasov <ja@xxxxxx>
> include/net/ip_vs.h | 32 +++++----------------
> net/netfilter/ipvs/ip_vs_conn.c | 12 ++++----
> net/netfilter/ipvs/ip_vs_core.c | 8 ------
> net/netfilter/ipvs/ip_vs_ctl.c | 26 +----------------
> net/netfilter/ipvs/ip_vs_sync.c | 7 +----
> net/netfilter/ipvs/ip_vs_xmit.c | 62 ++++++-----------------------------------
> 6 files changed, 23 insertions(+), 124 deletions(-)
>
> base-commit: 99676a5766412f3936c55b9d18565d248e5463ee
Regards
--
Julian Anastasov <ja@xxxxxx>
