Re: [RFC PATCHv2 2/4] ipvs: use kthreads for stats estimation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



	Hello,

On Fri, 9 Sep 2022, Julian Anastasov wrote:

> +add_est:
> +	ktid = kd->id;
> +	/* add_row points after the row we should use */
> +	crow = READ_ONCE(kd->add_row) - 1;
> +	if (crow < 0)
> +		crow = IPVS_EST_NTICKS - 1;
> +	row = crow;
> +	if (crow) {

	OK, not fatal but this should be

	if (crow < IPVS_EST_NTICKS - 1) {

> +		crow++;
> +		row = find_last_bit(kd->avail, crow);
> +	}
> +	if (row >= crow)
> +		row = find_last_bit(kd->avail, IPVS_EST_NTICKS);
> +

Regards

--
Julian Anastasov <ja@xxxxxx>




[Index of Archives]     [Linux Filesystem Devel]     [Linux NFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [X.Org]

  Powered by Linux