答复: [PATCH] ipvs:clean code for ip_vs_sync.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thank you for suggestion.
Firstly, I show an explanation for the second email.
Sorry, I forgot to CC myself in sending first email, which lead to I cannot know if it successfully.
So,I send it again.

And now, I will add a space after ipvs: in the subject and after Signed-off-by:.

-----邮件原件-----
发件人: Jakub Kicinski [mailto:kuba@xxxxxxxxxx] 
发送时间: 2020年7月16日 6:04
收件人: Zhouxudong (EulerOS) <zhouxudong8@xxxxxxxxxx>
抄送: wensong@xxxxxxxxxxxx; horms@xxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; lvs-devel@xxxxxxxxxxxxxxx; Chenxiang (EulerOS) <rose.chen@xxxxxxxxxx>
主题: Re: [PATCH] ipvs:clean code for ip_vs_sync.c

On Wed, 15 Jul 2020 12:18:39 +0000 zhouxudong199 wrote:
> Signed-off-by:zhouxudong199 <zhouxudong8@xxxxxxxxxx>

Thank you for the patch.

Please describe the changes you're making in the commit message, as far as I can tell you're adding missing spaces?

Please read this: https://kernelnewbies.org/KernelJanitors
and make sure to CC kernel-janitors@xxxxxxxxxxxxxxx

Please add a space after ipvs: in the subject and after Signed-off-by:

If you repost please make sure to mark the patch as v2.

> @@ -1232,7 +1232,7 @@ static void ip_vs_process_message(struct netns_ipvs *ipvs, __u8 *buffer,
>  		msg_end = buffer + sizeof(struct ip_vs_sync_mesg);
>  		nr_conns = m2->nr_conns;
>  
> -		for (i=0; i<nr_conns; i++) {
> +		for (i=0; i < nr_conns; i++) {

you should probably replace i=0 with i = 0.

>  			union ip_vs_sync_conn *s;
>  			unsigned int size;
>  			int retc;




[Index of Archives]     [Linux Filesystem Devel]     [Linux NFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [X.Org]

  Powered by Linux