Please keep the Reported-by notice, and reproducer will probably be useful too: IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+a46d6abf9d56b1365a72@xxxxxxxxxxxxxxxxxxxxxxxxx It will help syzbot understand when the bug is fixed. See footer for details. If you forward the report, please keep this part and the footer. syzbot hit the following crash on upstream commit 3eb2ce825ea1ad89d20f7a3b5780df850e4be274 (Sun Mar 25 22:44:30 2018 +0000) Linux 4.16-rc7 syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=a46d6abf9d56b1365a72 So far this crash happened 27 times on net-next, upstream. C reproducer: https://syzkaller.appspot.com/x/repro.c?id=6524202618191872 syzkaller reproducer: https://syzkaller.appspot.com/x/repro.syz?id=5383267238805504 Raw console output: https://syzkaller.appspot.com/x/log.txt?id=5136472378179584 Kernel config: https://syzkaller.appspot.com/x/.config?id=-8440362230543204781 compiler: gcc (GCC) 7.1.1 20170620 On Tue, Mar 27, 2018 at 9:52 PM, Julian Anastasov <ja@xxxxxx> wrote: > > Hello, > > On Tue, 27 Mar 2018, Florian Westphal wrote: > >> syzbot <syzbot+a46d6abf9d56b1365a72@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote: >> [ cc Julian and trimming cc list ] >> >> > syzkaller688027/4497 is trying to acquire lock: >> > (rtnl_mutex){+.+.}, at: [<00000000bb14d7fb>] rtnl_lock+0x17/0x20 >> > net/core/rtnetlink.c:74 >> >> > but task is already holding lock: >> > IPVS: stopping backup sync thread 4495 ... >> > (rtnl_mutex){+.+.}, at: [<00000000bb14d7fb>] rtnl_lock+0x17/0x20 >> > net/core/rtnetlink.c:74 >> > >> > other info that might help us debug this: >> > Possible unsafe locking scenario: >> > >> > CPU0 >> > ---- >> > lock(rtnl_mutex); >> > lock(rtnl_mutex); >> > >> > *** DEADLOCK *** >> > >> > May be due to missing lock nesting notation >> >> Looks like this is real, commit e0b26cc997d57305b4097711e12e13992580ae34 >> ("ipvs: call rtnl_lock early") added rtnl_lock when starting sync thread >> but socket close invokes rtnl_lock too: > > I see, thanks! I'll have to move the locks into > start_sync_thread and to split make_{send,receive}_sock > to {make,setup}_{send,receive}_sock ... > >> > stack backtrace: >> > rtnl_lock+0x17/0x20 net/core/rtnetlink.c:74 >> > ip_mc_drop_socket+0x88/0x230 net/ipv4/igmp.c:2643 >> > inet_release+0x4e/0x1c0 net/ipv4/af_inet.c:413 >> > sock_release+0x8d/0x1e0 net/socket.c:595 >> > start_sync_thread+0x2213/0x2b70 net/netfilter/ipvs/ip_vs_sync.c:1924 >> > do_ip_vs_set_ctl+0x1139/0x1cc0 net/netfilter/ipvs/ip_vs_ctl.c:2389 > > Regards > > -- > Julian Anastasov <ja@xxxxxx> > > -- > You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. > To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/alpine.LFD.2.20.1803272227370.3460%40ja.home.ssi.bg. > For more options, visit https://groups.google.com/d/optout. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html