Re: [PATCH net-next,v3 03/14] ipvs: Handle inverse and icmp headers in ip_vs_leave

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



	Hello,

On Tue, 25 Aug 2015, Alex Gartrell wrote:

> -	if ((svc->port == FTPPORT) && (pptr[1] != FTPPORT))
> +	if (svc->port == FTPPORT && dport != FTPPORT)
>  		return NF_ACCEPT;

	Not sure if we have chance for this merge window
but only small things for patches 3 and 4 need to be fixed:

Patch 1: OK
Patch 2: OK

Patch 3:
	- We need to prevent ICMP-to-ICMP in ip_vs_leave:

	if (svc->port == FTPPORT && dport != FTPPORT)
		return NF_ACCEPT;

+	if (ip_vs_iph_icmp(iph))
+		return NF_DROP;

Patch 4:
	- I now see that first IP_VS_DBG_PKT in ip_vs_try_to_schedule
needs iph->off instead of 0.

Patch 5: OK
Patch 6: OK
Patch 7: OK
Patch 8: OK
Patch 9: OK
Patch 10: OK
Patch 11: OK
Patch 12: OK
Patch 13: OK
Patch 14: OK

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Devel]     [Linux NFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [X.Org]

  Powered by Linux