Re: [lvs-users] [PATCH net] ipvs: do not use random local source address for tunnels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 27, 2015 at 02:39:30PM +0300, Julian Anastasov wrote:
> Michael Vallaly reports about wrong source address used
> in rare cases for tunneled traffic. Looks like
> __ip_vs_get_out_rt in 3.10+ is providing uninitialized
> dest_dst->dst_saddr.ip because ip_vs_dest_dst_alloc uses
> kmalloc. While we retry after seeing EINVAL from routing
> for data that does not look like valid local address, it
> still succeeded when this memory was previously used from
> other dests and with different local addresses. As result,
> we can use valid local address that is not suitable for
> our real server.
> 
> Fix it by providing 0.0.0.0 every time our cache is refreshed.
> By this way we will get preferred source address from routing.
> 
> Reported-by: Michael Vallaly <lvs@xxxxxxxxxxxxx>
> Fixes: 026ace060dfe ("ipvs: optimize dst usage for real server")
> Signed-off-by: Julian Anastasov <ja@xxxxxx>

Thanks, I have applied this to the ipvs tree.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Devel]     [Linux NFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [X.Org]

  Powered by Linux