On Sat, Aug 10, 2013 at 03:31:03PM +0300, Julian Anastasov wrote: > > Hello, > > On Sat, 10 Aug 2013, Simon Kirby wrote: > > > On Fri, Aug 09, 2013 at 12:02:11PM +0300, Julian Anastasov wrote: > > > > > Looks good to me, even if you add space > > > between "(__s64)" cast and "loh"/"doh". > > > > I think (__s64)loh * doh makes more sense as the cast applies to the > > variable before the multiply is evaluated. > > OK > > > > But after your fix for ip_vs_dest_conn_overhead > > > I see that also ip_vs_nq_dest_overhead and ip_vs_sed_dest_overhead > > > need to return int instead of unsigned int. I'll ack > > > v2 with these changes. > > > > Ok, fixed. :) > > Thanks! > > > > Also, shorter subject is preferred, you can use > > > 'ipvs: fix overflow on dest weight multiply' or something > > > else that you feel is better, '()' and '*' does not look > > > good in subject. Thanks! > > > > -- 8< -- > > > > Schedulers such as lblc and lblcr require the weight to be as high as the > > maximum number of active connections. In commit b552f7e3a9524abcbcdf, the > > consideration of inactconns and activeconns was cleaned up to always > > count activeconns as 256 times more important than inactconns. In cases > > where 3000 or more connections are expected, a weight of 3000 * 256 * > > 3000 connections overflows the 32-bit signed result used to determine if > > rescheduling is required. > > > > On amd64, this merely changes the multiply and comparison instructions to > > 64-bit. On x86, a 64-bit result is already present from imull, so only > > a few more comparison instructions are emitted. > > > > Signed-off-by: Simon Kirby <sim@xxxxxxxxxx> > > Acked-by: Julian Anastasov <ja@xxxxxx> > > Horms, please apply! Sure, will do. I am on vacation until the 21st and thus my net access is somewhat sporadic. I apologise that this may delay me pushing this patch to ipvs-next. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
