Hello,
On Tue, 9 Nov 2010, Simon Horman wrote:
I have added this and the other patches that I am completely happy with
to the staging branch of lvs-test-2.6.
Specifically the patches in there are:
* IPVS: Only match pe_data created by the same pe
* IPVS: Add persistence engine to connection entry
* IPVS: Backup, Adding structs for new sync format
* IPVS: Prepare for transferring firewall marks (fwmark) to the backup daemon.
* IPVS: ip_vs_pe.c, use strncmp to be safe.
Using if (strncmp(pe_name, pe->name, IP_VS_PENAME_MAXLEN )==0
does not look useful. If the goal is to match data from
sync message I expect to see the already discussed check
for pe_name_len, for example:
if (!strncmp(pe_name, pe->name, pe_name_len) &&
!pe->name[pe_name_len])
and somewhere check for pe_name_len > 0.
If you are unhappy with any of those changes let me know,
I'm happy to revert and rebase the staging branch
(its mainly for your benefit at this stage).
I would also like to add the following clean-up changes,
could I get an Ack or Nack from you on each of them?
I don't see problem here:
* IPVS: Make the cp argument to ip_vs_sync_conn() static
http://www.spinics.net/lists/lvs-devel/msg01375.html
* IPVS: Remove useless { } block from ip_vs_process_message()
http://www.spinics.net/lists/lvs-devel/msg01369.html
* IPVS: buffer argument to ip_vs_process_message() should not be const
http://www.spinics.net/lists/lvs-devel/msg01377.html
Regards
--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
