On Thu, Oct 21, 2010 at 09:51:40AM +0200, Hans Schillstrom wrote: > On Wednesday 20 October 2010 16:03:24 Simon Horman wrote: > > On Fri, Oct 08, 2010 at 01:16:57PM +0200, Hans Schillstrom wrote: [ snip ] > > > @@ -278,35 +271,41 @@ ip_vs_conn_in_get_proto(int af, const struct sk_buff *skb, > > > unsigned int proto_off, int inverse) > > > { > > > __be16 _ports[2], *pptr; > > > + struct net *net = dev_net(skb->dev); > > > > > > pptr = skb_header_pointer(skb, proto_off, sizeof(_ports), _ports); > > > if (pptr == NULL) > > > return NULL; > > > > > > + BUG_ON(!net); > > > > Can you explain why BUG_ON is here? > > Yes, I forgot to remove it. > I had them every where to make sure that net ptr was set, > - don't call me paranoid ;-) Thanks, I thought it was something like that. I'll remove them as part of my rebase. [ strip ] -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html