On Thursday 2009-10-01 01:09, Joe Perches wrote: >On Thu, 2009-10-01 at 00:46 +0200, Jan Engelhardt wrote: >> On Thursday 2009-10-01 00:37, Joe Perches wrote: >> >This centralizes the definition and removes the >> >replicated #defines from all files > >I think this increased command line length hardly matters. > >I think a reasonable complaint might be that it separates >the definition of a macro from the code. I think it's >similar to the already used KBUILD_MODNAME macro though. KBUILD_MODNAME is special in that it is derived from the actual source filename. Of course you could put #define KBUILD_MODNAME "foo" in your source file, but that is like putting changelogs there when they belong into the git log. >> How about an #include file for the ipvs private things? > >It's not just IPVS, this style could be used treewide >without requiring extra #includes. Well I personally prefer the #include instead of hiding such in Makefiles. You know, when newcomers could start doing `grep KMSG_COMPONENT *.[ch]`. Perhaps GCC's -include flag in a Makefile to avoid #includes in .c files? -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
