On Mon, Sep 08, 2008 at 11:30:08AM +0200, Julius Volz wrote: > On Mon, Sep 8, 2008 at 3:48 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > > On Sat, Sep 06, 2008 at 11:26:29AM +0200, Julius Volz wrote: > >> On Sat, Sep 6, 2008 at 6:14 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > >> > On Fri, Sep 05, 2008 at 01:40:31PM +0200, Julius Volz wrote: > >> >> Hi, > >> >> > >> >> Just some minor things: > >> > > >> > Hi Julius, > >> > > >> > thanks for pointing these out. I will send patches to fix these problems ASAP. > >> > >> Thanks, looking good! > > > > I took the liberty of taking that response as an Acked-by. > > I've applied these minor changes now. > > > > Thanks! I'll remember to add an explicit Acked-by in the future. > > I'll try out your new checksumming patches now and see if everything > works for me (for both remote connections and ones from the > director)... Thanks, much appericated. I'm also a little concerned about the handling of IPv6 ICMP in this patch. In particular, we need to ensure that the pseudo-header is included in the checksum. Which it may not be, as I based the code on the IPv4 version. http://rfc-ref.org/RFC-TEXTS/1883/chapter8.html#d4e447886 -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
