On Tue, Sep 2, 2008 at 9:40 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Mon, Sep 01, 2008 at 02:56:13PM +0200, Julius Volz wrote: >> Add Netfilter hook functions or modify existing ones, if possible, to >> process IPv6 packets. Some support functions are also added/modified for >> this. ip_vs_nat_icmp_v6() was already added in the patch that added the v6 >> xmit functions, as it is called from one of them. >> >> Signed-off-by: Julius Volz <juliusv@xxxxxxxxxx> > > Please run checkpatch.pl over this patch. > >> 1 files changed, 326 insertions(+), 36 deletions(-) >> >> diff --git a/net/ipv4/ipvs/ip_vs_core.c b/net/ipv4/ipvs/ip_vs_core.c >> index 8bfd7c2..0bf871c 100644 >> --- a/net/ipv4/ipvs/ip_vs_core.c >> +++ b/net/ipv4/ipvs/ip_vs_core.c >> @@ -39,6 +39,11 @@ >> #include <linux/netfilter.h> >> #include <linux/netfilter_ipv4.h> >> >> +#ifdef CONFIG_IP_VS_IPV6 >> +#include <net/ipv6.h> >> +#include <linux/netfilter_ipv6.h> >> +#endif >> + >> #include <net/ip_vs.h> >> >> >> @@ -60,6 +65,7 @@ EXPORT_SYMBOL(ip_vs_get_debug_level); >> >> /* ID used in ICMP lookups */ >> #define icmp_id(icmph) (((icmph)->un).echo.id) >> +#define icmpv6_id(icmph) (icmph->icmp6_dataun.u_echo.identifier) > > Should this be ((icmph)->icmp6_dataun.u_echo.identifier) ? Ah yeah, that is safer, thanks! -- Julius Volz - Corporate Operations - SysOps Google Switzerland GmbH - Identification No.: CH-020.4.028.116-1 -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html