Re: [PATCH RFC 08/24] IPVS: Make protocol handler functions support IPv6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Julius Volz wrote:
Still, I think my original interpretation was correct? It's always
used with constant values and there are many usages similar to this:

skb->protocol = __constant_htons(ETH_P_802_3);

Someone feel free to correct me.

I know it's a minor point, but look at tcp_ipv6.c:

        if (skb->protocol == htons(ETH_P_IP))
                return tcp_v4_conn_request(sk, skb);

That's different from the code you quoted that's doing an assignment. __constant_htons() isn't used anywhere in an if() statement, although I did find a couple in the bonding driver that should be fixed.

-Brian
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Devel]     [Linux NFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]     [X.Org]

  Powered by Linux