On Thu, 22 Sep 2011, Zdenek Kabelac wrote: > Dne 22.9.2011 11:28, Lukas Czerner napsal(a): > > On Wed, 21 Sep 2011, Stephane Chazelas wrote: > > > >> 2011-09-21 18:45:20 +0200, Lukas Czerner: > >>> Create command provides the functionality of creating a new logical > >>> volumes including defined file system. > >>> > >>> This commit also changes the way how are commands recognised an > >>> executed. The new approach is more suitable for bigger number of > >>> commands. > >> > >> There are so many shell scripting bad practices in there that I > >> thought I had to reply. > > > > Great, that's what I need, Thanks! > > > >> > So above: > >> > >> TOOL=$(basename -- "$0") > >> > >>> > >>> _SAVEPATH=$PATH > >> > >> Why would you need to save $PATH? > > > > Yeah, that is something I would like to know as well :) I have actually > > removed this in patch 24 since it does not make sense to change PATH in > > this script. > > When we are at this one - this commit definitely does not belong into the > fsadm update patch set - such patch should be submitted as a separate > unrelated patch and not 'well' hidden in the middle - and there are more such > things which should probably go separately - especially if they present some > bugfixes and should be merged before this large fsadm gets slowly upstream. > > Zdenek > The patch removing the PATH think is in the separate path, and I mentioned above. Regarding more bug fixes, I am not sure what do you mean specifically, some of them are separate patches and some of them might be unfortunately part of other patches. The reason is simple, I have extended fsadm from 494 lines to 1486 lines with series of patches, improvements and new features. I would be painful to identify each and every bug fix and create separate patch, which will go through separate merging process especially since it is a single file script. Also the patch is not "well" hidden, it is just a part of the series and it is done after all the big changes I have made. Thanks! -Lukas _______________________________________________ linux-lvm mailing list linux-lvm@redhat.com https://www.redhat.com/mailman/listinfo/linux-lvm read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
