Dne 21.9.2011 18:45, Lukas Czerner napsal(a):
> Remove command allows to remove unused devices from the pool (volume
> group).
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> scripts/fsadm.sh | 82 ++++++++++++++++++++++++++++++++++++++++-------------
> 1 files changed, 62 insertions(+), 20 deletions(-)
>
> diff --git a/scripts/fsadm.sh b/scripts/fsadm.sh
> index 6617de0..4a4f625 100755
> --- a/scripts/fsadm.sh
> +++ b/scripts/fsadm.sh
> @@ -823,11 +823,12 @@ list_filesystems() {
> IFS=$NL
> local c=0
> for line in $(LANG=C $LVM lvs -o lv_path,lv_size,segtype --noheadings --separator ' ' --nosuffix --units k 2> /dev/null); do
> - c=$((c+1))
> line=$(echo $line | sed -e 's/^ *\//\//')
> volume=$(echo $line | cut -d' ' -f1)
> - volumes[$c]=$volume
> - segtype[$c]=$(echo $line | cut -d' ' -f3)
> + [ "$volume" == "$last_volume" ] && continue
> + c=$((c+1))
> + local volumes[$c]=$volume
> + local segtype[$c]=$(echo $line | cut -d' ' -f3)
> detect_fs $volume
> detect_mounted
> detect_fs_size
Could you please update/cleanup the patch set - so it doesn't rework same code
multiple times over and over ?
(It's a waste of time to review new code, which gets replaced several times
during the whole patch set)
Thanks
Zdenek
_______________________________________________
linux-lvm mailing list
linux-lvm@redhat.com
https://www.redhat.com/mailman/listinfo/linux-lvm
read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
