Hi.
On Wed, 2008-07-16 at 18:42 +0100, Alasdair G Kergon wrote:
> Quick way for starters, is allocate a pointless object in the pool
> then free eveything back to that point each time round the loop.
>
> But proper thing is to track down into the library and find
> which routines are the ones where the pool can be freed at
> the end and isn't being.
>
> IOW where are most of those allocations happening?
>
> Alasdair
Okay. Unless we really find a better way to do it, here is the suggested marker version.
As far as I can tell so far, this works equally well.
Best,
Daniel
diff -r f79956e87d1d -r 6a69ebd5ade1 tools/vgchange.c
--- a/tools/vgchange.c Mon Jul 14 18:16:03 2008 -0700
+++ b/tools/vgchange.c Wed Jul 16 13:15:32 2008 -0700
@@ -57,10 +57,17 @@ static int _activate_lvs_in_vg(struct cm
struct lv_list *lvl;
struct logical_volume *lv;
const char *pvname;
+ void *marker;
int count = 0;
list_iterate_items(lvl, &vg->lvs) {
lv = lvl->lv;
+
+ marker = dm_pool_alloc(cmd->mem, 1);
+ if (!marker) {
+ log_error("Out of memory");
+ return count;
+ }
/* Only request activation of snapshot origin devices */
if ((lv->status & SNAPSHOT) || lv_is_cow(lv))
@@ -98,6 +105,8 @@ static int _activate_lvs_in_vg(struct cm
pvmove_poll(cmd, pvname, 1);
continue;
}
+
+ dm_pool_free(cmd->mem, marker);
count++;
}
_______________________________________________
linux-lvm mailing list
linux-lvm@redhat.com
https://www.redhat.com/mailman/listinfo/linux-lvm
read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
