On Sun, Jul 01, 2007 at 04:58:00PM +0200, Arkadiusz Miskiewicz wrote: > Please merge this one, too: > http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/lvm2-as-needed.patch Yep. > The other one puts LDFLAGS (linker flags) not CFLAGS (cflags is for > compilation, ldflags for linking) and changes order so linking will success > when using -Wl,--as-needed flag. For fsadm, which I don't consider production-ready yet - but if you're using it successfully that'd be nice to know! > There are also others mostly self explaining patches for device-mapper: > http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/device-mapper-disable_dynamic_link.patch Want to test that one - how does it handle configure --disable-dynamic without --enable-static? (A nice error message? Is there a cleaner way?) > http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/device-mapper-force-local-headers.patch Not sure what the best way to achieve that upstream is: the patch breaks some valid alternative configurations. > http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/device-mapper-getopt.patch OK > http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/device-mapper-klibc.patch basename: I'd rather call a local implementation if 'configure' didn't find one fread+sscanf: I'd prefer not to change that at this stage unless you can show if fixes bugs in the existing implementation (it's not easy to get this sort of code correct, so any change involves avoidable risk) - again an alternative function implementation (possibly with a little refactoring) would be more acceptable. Alasdair -- agk@redhat.com _______________________________________________ linux-lvm mailing list linux-lvm@redhat.com https://www.redhat.com/mailman/listinfo/linux-lvm read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
