On Tue, 2 Apr 2002 08:59, Nathan Scott wrote: > On Fri, Mar 29, 2002 at 10:26:41PM +1000, Adrian Head wrote: > > I have also run into the XFS CVS kernel compile failing because of an > > undefined DQUOT_SYNC. > > > > Using the information given by Nathan I have tracked down the offending > > patch that causes the problems. In my case it was the LVM VFS-lock patch > > from the Sistina LVM project. What they seem to do is use DQUOT_SYNC to > > force the writing of cached Quota infomation before they lock the VFS > > during snapshot creation. It would also seem that EVMS does the same > > thing. > > Aha, thanks for tracking this down Adrian. No worries - thanks for the original info that got me started in the correct direction. > > > I expect that the XFS CVS kernel tree is actually ahead of the standard > > 2.4.18 kernel tree in this respect so we'll have to wait until 2.4.19 is > > released with the updated API's before other projects update their kernel > > patches. > > Yes, the XFS trees contain all of the quota patches from: > ftp://atrey.karlin.mff.cuni.cz/pub/local/jack/quota/v2.4/ > > I wouldn't expect these patches to be in 2.4.19 -- they are > not in 2.5 yet and I think Jan is concentrating on that step > first. Fine - as I would expect. > > > Grep'ing through the kernel I have not been able to find any comments or > > explanations regarding this - so I have assumed that DQUOT_SYNC can be > > changed to DQUOT_SYNC_DEV without problems. > > Yes, by my understanding of the VFS quota subsystem that would > be the correct thing to do. Thanks - my concern at the time was whether DQUOT_SYNC_SB should be included as well. I had difficulty tracing it through so I took the easier way and assumed that it wasn't needed. ;-) > > > After making that change the kernel compiles cleanly and boots. I'm > > unsure as yet if I have done the correct thing here. Hopefuly someone > > will be able to help us out and correct me if I'm incorrect. > > I believe your change is correct, I've CC'd Jan in case there is > anything that I've overlooked. Thanks Nathan & Jan - if I don't get any feedback I will assume that everything is OK and I will post patches to the LVM list latter today explaining & fixing the issue with their VFS-lock patch. > > cheers. -- Adrian Head (Public Key available on request.) _______________________________________________ linux-lvm mailing list linux-lvm@sistina.com http://lists.sistina.com/mailman/listinfo/linux-lvm read the LVM HOW-TO at http://www.sistina.com/lvm/Pages/howto.html
