On Tue, Aug 4, 2015 at 1:08 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > Hi Justin, > > On Tue, Aug 04, 2015 at 12:45:31PM -0700, Justin Maggard wrote: >> Add support for the IT8732F. This chip is pretty similar to IT8721F, >> with the main difference being that the ADC LSB is 10.9 mV instead of >> 12 mV. >> > > I assume you have a datasheet. Since you say "main difference", > are you aware of any other differences ? Would it by any chance > be possible to share the datasheet with us ? > Yes, I do have a datasheet. I'm investigating our confidentiality obligations now, but I'm unsure what that outcome will be. I don't have datasheets for any other chips, so I can't really do a proper comparison. But the driver code for IT8721F seems to line up well with the IT8732F datasheet. IT8732F has up to 4 fan tachometer inputs, and up to 4 PWM outputs. The "SmartGuardian" piece appears identical. As I mentioned in the doc change, it also has a fan tachometer closed-loop mode that seems new (at least I didn't see any reference to it in the driver). That gets enabled by setting IT87_REG_PWM to automatic mode, and also setting bit 2. Temp sensors appear identical, with the obvious exception of the 10.9 mV ADS LSB. > Further comments inline. > OK, I'll whip up a v2 patch shortly to address your comments. -Justin _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
