On Wed, 15 Jul 2015 18:04:13 +0200, Lukasz Odzioba wrote: > Removes the limits of supported CPU cores and max core ID. I see the benefit of removing the arbitrary limit, but why use a list instead of a dynamically allocated array? This is turning a O(1) algorithm into a O(n) algorithm. I know n isn't too large in this case but I still consider it bad practice if it can be avoided. Do you expect core IDs to become arbitrarily large? Significantly larger than the core count? You need a better patch description for sure. Saying what the patch does isn't sufficient, you need to explain why this is needed and why this is the right way to do it. -- Jean Delvare SUSE L3 Support _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
