Re: [PATCH 1/2] hwmon: (nct6775) Add missing sysfs attibute initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 29, 2015 at 10:49 AM, Jean Delvare <jdelvare@xxxxxxx> wrote:
> On Thu, 28 May 2015 09:15:55 -0700, Guenter Roeck wrote:
>> The following error message is seen when loading the nct6775 driver
>> with DEBUG_LOCK_ALLOC enabled.
>>
>> BUG: key ffff88040b2f0030 not in .data!
>> ------------[ cut here ]------------
>> WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
>>                               lockdep_init_map+0x469/0x630()
>> DEBUG_LOCKS_WARN_ON(1)
>>
>> Caused by a missing call to sysfs_attr_init() when initializing
>> sysfs attributes.
>>
>> Reported-by: Alexey Orishko <alexey.orishko@xxxxxxxxx>
>> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>> ---
>>  drivers/hwmon/nct6775.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
>> index 4fcb48103299..bd1c99deac71 100644
>> --- a/drivers/hwmon/nct6775.c
>> +++ b/drivers/hwmon/nct6775.c
>> @@ -995,6 +995,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
>>                                (*t)->dev_attr.attr.name, tg->base + i);
>>                       if ((*t)->s2) {
>>                               a2 = &su->u.a2;
>> +                             sysfs_attr_init(&a2->dev_attr.attr);
>>                               a2->dev_attr.attr.name = su->name;
>>                               a2->nr = (*t)->u.s.nr + i;
>>                               a2->index = (*t)->u.s.index;
>> @@ -1005,6 +1006,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
>>                               *attrs = &a2->dev_attr.attr;
>>                       } else {
>>                               a = &su->u.a1;
>> +                             sysfs_attr_init(&a->dev_attr.attr);
>>                               a->dev_attr.attr.name = su->name;
>>                               a->index = (*t)->u.index + i;
>>                               a->dev_attr.attr.mode =
>
> Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

Tested on ASRock E3C222D4U motherboard with kernel 4.0.3; reported
problem is fixed.
Tested-by: Alexey Orishko <alexey.orishko@xxxxxxxxx>

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux