Re: [PATCH 2/2] hwmon: (nct6683) Add missing sysfs attibute initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 29 May 2015 13:24:10 -0700, Guenter Roeck wrote:
> Hi Jean,
> 
> On 05/29/2015 01:50 AM, Jean Delvare wrote:
> 
> > Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>
> >
> > Looks like the abituguru and abituguru3 drivers suffer from the same
> > bug?
> >
> 
> Those drivers derive the attr values from a template which is pre-initialized
> with SENSOR_ATTR_2. With this, the initialization should be taken care of.
> Am I missing something ?

Probably not. My naive assumption was based on the lack of
sysfs_attr_init() call in these drivers. If the initialization is done
differently then alright. Thanks for verifying.

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux