Re: [PATCH v2 03/22] hwmon: (it87) Add AVCC3 support for IT8620E

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/09/2015 04:55 AM, Jean Delvare wrote:
Hi Guenter,

On Sat,  4 Apr 2015 14:54:54 -0700, Guenter Roeck wrote:
AVCC3 is supported on IT8620E, similar to IT8603E. Add feature flag
to indicate AVCC3 support, and enable support for it on IT8620E.

Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
---
v2: Use feature macro on sio_data

  drivers/hwmon/it87.c | 23 ++++++++++++++---------
  1 file changed, 14 insertions(+), 9 deletions(-)
(...)

Looks good.

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

Makes me wonder, did you check if PWM outputs support full-speed mode
on the IT8620E? That's the only it8603-specific piece of code left in
the driver, and apparently the IT8620E and IT8603E have a few things in
common.

Yes, it does support full-speed mode, at least according to the datasheet.

But on the other side it looks like AVCC3 is not really at 0x2f, or it
reports nonsense, despite the datasheet claiming it to be there.
Or there is a bug in my code ;-).

Too bad I don't have the datasheet for IT8603E :-(.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux