On 03/30/2015 09:35 AM, Jean Delvare wrote:
Le Monday 30 March 2015 à 08:10 -0700, Guenter Roeck a écrit :
[ ... ]
+/*
+ * pwm base frequencies. The frequency has to be divided by either 128 or 256,
+ * depending on the chip type, to calculate the actual pwm frequency.
+ *
+ * Some of the chip datasheets suggest a base frequency of 51kHz instead
+ * of 750kHz for the slowest base frequency, resulting in a pwm frequency
+ * of 200Hz. Sometimes both pwm frequency select registers are affected,
+ * sometimes just one. It is unknown if this is a datasheet error or real,
+ * so this is ignored for now.
Leaving a space between the number and kHz or Hz makes it easier to
read IMHO. I would also capitalize PWM everywhere.
Other than these minor suggestions, this looks good, good catch! I never
noticed this difference between the various chips.
Hi Jean,
I made those changes. Should I resubmit, or do I have your Reviewed-by: ?
You have it of course, sorry I thought I had put it already but it seems
not.
Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>
Thanks!
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
