Re: [PATCH v2] hwmon: (i5500_temp) Don't bind to disabled sensors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Henrique,

On Thu, 23 Oct 2014 21:28:48 -0200, Henrique de Moraes Holschuh wrote:
> On Thu, 23 Oct 2014, Jean Delvare wrote:
> > On many motherboards, for an unknown reason, the thermal sensor seems
> > to be disabled and will return a constant temperature value of 36.5
> > degrees Celsius. Don't bind to the device in that case, so that we
> > don't report this bogus value to userspace.
> 
> ...
> 
> > +	if (tsfsc == 0x7F && tstimer == 0x07D30D40) {
> > +		dev_warn(&pdev->dev, "Sensor seems to be disabled\n");
> > +		return -ENODEV;
> 
> If this is an autoloadable module, and this sensor is very often disabled,
> shouldn't this be dev_info() or dev_notice()?

This is a good point, I've degraded the message to dev_notice(). Thanks
for the suggestion!

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux