Re: [PATCH 3/3] hwmon: (i5500_temp) Don't bind to disabled sensors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/22/2014 02:13 AM, Jean Delvare wrote:
On many motherboards, for an unknown reason, the thermal sensor seems
to be disabled and will return a constant temperature value of 36.5
degrees Celsius. Don't bind to the device in that case, so that we
don't report this bogus value to userspace.

Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
Cc: Romain Dolbeau <romain@xxxxxxxxxxx>
Cc: Guenter Roeck <linux@xxxxxxxxxxxx>

Assuming there is no simple better way:

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Guenter

---
As suggested by Guenter.

  drivers/hwmon/i5500_temp.c |    7 +++++++
  1 file changed, 7 insertions(+)

--- linux-3.17.orig/drivers/hwmon/i5500_temp.c	2014-10-22 10:22:18.526856485 +0200
+++ linux-3.17/drivers/hwmon/i5500_temp.c	2014-10-22 10:55:22.700413828 +0200
@@ -121,6 +121,7 @@ static int i5500_temp_probe(struct pci_d
  {
  	int err;
  	struct device *hwmon_dev;
+	s8 tsfsc;

  	err = pci_enable_device(pdev);
  	if (err) {
@@ -128,6 +129,12 @@ static int i5500_temp_probe(struct pci_d
  		return err;
  	}

+	pci_read_config_byte(pdev, REG_TSFSC, &tsfsc);
+	if (tsfsc == 0x7F) {
+		dev_warn(&pdev->dev, "Sensor seems to be disabled\n");
+		return -ENODEV;
+	}
+
  	hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev,
  							   "intel5500", NULL,
  							   i5500_temp_groups);




_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors




[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux