Re: [PATCH 3/3] hwmon: (i5500_temp) Don't bind to disabled sensors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2014-10-22 11:13 GMT+02:00 Jean Delvare <jdelvare@xxxxxxx>:
> On many motherboards, for an unknown reason, the thermal sensor seems
> to be disabled and will return a constant temperature value of 36.5
> degrees Celsius. Don't bind to the device in that case, so that we
> don't report this bogus value to userspace.

36.5°C might be a legitimate value - for instance, if the driver is loaded
after a cold boot in a temperature-controlled machine room, the properly
cooled chipset might not have reached 37°C yet, so the chip will legitimately
report 0x7F in TSFSC...

I _think_ a safer way would be to check variability - if it's not 0x7F
then fine, it's likely working. If is is, then drop TSTHRTHI by ~30°C ;
if TSFSC still reports 0x7F then it's definitely wrong since that would
be 6.5°C (machine room in the [ant]arctic where that would still be legit
shouldn't worry about chipset temperature anyway :-)

OTOH, just loading the driver a couple of minutes after boot would work
with your current test.

Cordially,

-- 
Romain Dolbeau

_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors





[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux