Hi Guenter, On Tue, 21 Oct 2014 09:48:39 -0700, Guenter Roeck wrote: > On Tue, Oct 21, 2014 at 09:03:37AM +0200, Jean Delvare wrote: > > The Intel 5500, 5520 and X58 chipsets embed a digital thermal sensor. > > This new driver supports it. > > > > Note that on many boards the sensor seems to be disabled and reports > > the minimum value (36.5 degrees Celsius) all the time. > > Guess that explains why it doesn't work for me. Which CPU, board, chipset and revision? > Is it possible to detect that condition and fail to load the driver > if the sensor is disabled, or to enable the sensor in the driver > in that case ? We currently have no idea how to enable the sensor, this is the problem :-( If you find out how to do that, please let me know. Or I may ask Intel about it, maybe someone knows there. So far only Intel boards have a working sensor. We can't cleanly fail to load the driver, as the detection of the faulty condition would happen at device probe time. We could decline the probe though, so that the non-working sensor doesn't show up in "sensors". > Personally I would not bother with a timed update function for this driver; > pcie accesses are not as expensive as i2c accesses. Other than that, What happens if a random user reads from the sysfs files in a tight loop then? Can't he/she saturate the PCIe link and cause higher latency or limited throughput for other PCIe devices? > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > for both patches. Thanks. -- Jean Delvare SUSE L3 Support _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors