On Wed, Aug 27, 2014 at 07:53:06PM +0200, Andreas Werner wrote: > Added driver to support the 14F021P00 BMC Hardware Monitoring. > The BMC is a Board Management Controller including monitoring of the > board voltages. > > Signed-off-by: Andreas Werner <andreas.werner@xxxxxx> Looks good, though I do have one comment ... > + > + hwmon_dev = devm_hwmon_device_register_with_groups(&pdev->dev, > + "menf21bmc", drv_data, > + menf21bmc_hwmon_groups); > + if (IS_ERR(hwmon_dev)) > + return PTR_ERR(hwmon_dev); > + > + dev_info(&pdev->dev, "MEN 14F021P00 BMC hwmon device enabled"); > + You removed the dev_info from the mfd driver but left it in the client drivers. If you'd drop it here as well, you could use 'return PTR_ERR_OR_ZERO(hwmon_dev);'. Just a suggestion, not mandatory. Either case, Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> I assume this will go in through the mfd tree. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
