On Wed, 27 Aug 2014, Andreas Werner wrote:
> On Wed, Aug 27, 2014 at 08:26:33AM +0100, Lee Jones wrote:
> > On Tue, 26 Aug 2014, Andreas Werner wrote:
> > > The MEN 14F021P00 Board Management Controller provides an
> > > I2C interface to the host to access the feature implemented in the BMC.
> > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikroelektronik
> > > and on a few Box/Display Computer.
> > >
> > > Added MFD Core driver, supporting the I2C communication to the device.
> > >
> > > The MFD driver currently supports the following features:
> > > - Watchdog
> > > - LEDs
> > > - Hwmon (voltage monitoring)
> > >
> > > Signed-off-by: Andreas Werner <andreas.werner@xxxxxx>
> > > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > > ---
> > > drivers/mfd/Kconfig | 12 +++++
> > > drivers/mfd/Makefile | 1 +
> > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 145 insertions(+)
> > > create mode 100644 drivers/mfd/menf21bmc.c
> > >
> > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > > index b8d9ca0..6a9f101 100644
> > > --- a/drivers/mfd/Kconfig
> > > +++ b/drivers/mfd/Kconfig
> > > @@ -453,6 +453,18 @@ config MFD_MAX8998
> > > additional drivers must be enabled in order to use the functionality
> > > of the device.
> > >
> > > +config MFD_MENF21BMC
> > > + tristate "MEN 14F021P00 Board Management Controller Support"
> > > + depends on I2C
> > > + select MFD_CORE
> > > + help
> > > + Say yes here to add support for the MEN 14F021P00 BMC
> > > + which is a Board Management Controller connected to the I2C bus.
> > > + The device supports multiple sub-devices like LED, HWMON and WDT.
> >
> > Nit: Whitespace error.
> >
>
> I run checkpatch but did not find any whitespace error.
> Where is it?
After 'HWMON'.
> > > +MODULE_DEVICE_TABLE(i2c, menf21bmc_id_table);
> > > +
> > > +static struct i2c_driver menf21bmc_driver = {
> > > + .driver.name = "menf21bmc",
> > > + .id_table = menf21bmc_id_table,
> > > + .probe = menf21bmc_probe,
> > > + .remove = menf21bmc_remove,
> > > +};
> >
> > No DT support?
> >
>
> No not at the moment because it is used only on x86 system.
Ah okay. Shouldn't the Kconfig depend on X86 then? What about ACPI?
> > > +module_i2c_driver(menf21bmc_driver);
> > > +
> > > +MODULE_DESCRIPTION("MEN 14F021P00 BMC mfd core driver");
> >
> > s/mfd/MFD
> >
> > > +MODULE_AUTHOR("Andreas Werner <andreas.werner@xxxxxx>");
> > > +MODULE_LICENSE("GPL v2");
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
