On Sat, Aug 23, 2014 at 08:10:16AM -0700, Guenter Roeck wrote: > Sorry I didn't have time to review the code myself. I'll have > to check the datasheet about turning regulators on and off. > Using page 0xff for the lm2978 looks wrong, as the chip supports > up to 8 channels which should be controlled separately > (I would assume) instead of turning them all on and off in > one go. Maybe I am missing something, but my assumption would > have been to have a separate regulator for each channel, and > that each channel would have its own regulator which would be BTW I should point out that my review is just for the regulator API aspects of the change, I have no knowledge of this hardware. If what you're saying matches the hardware I'd definitely expect to see one regulator registered per physical regulator rather than a single regulator for everything on the device.
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
