On Thu, Aug 21, 2014 at 08:26:22PM -0500, Mark Brown wrote: > On Thu, Aug 21, 2014 at 06:18:10PM -0700, Guenter Roeck wrote: > > On Thu, Aug 21, 2014 at 07:36:50PM -0500, Mark Brown wrote: > > > On Thu, Aug 21, 2014 at 05:21:26PM -0500, atull@xxxxxxxxxxxxxxxxxxxxx wrote: > > > > This all looks very much like pmbus could use regmap and then the regmap > > > helpers. I'd not insist on it though. What I would however suggest is > > > Not unless regmap got extended recently to support quick, byte, and word > > smbus accesses at the same time. > > Depending on how you decide which it quite possibly does - if it's based > on the register number that'd work. Mostly per register, but also per chip (for manufacturing specific registers the register size is determined by the chip type). Also, there are block registers. Plus, the scope of each register (ie if it is paged or not) is chip specific. The same register may be paged on one chip, and unpaged on another. I'll have another look to see if that all can be mapped into the regmap model. If yes, it might actually be quite helpful and might simplify the pmbus code quite a bit. Either case, even if regmap now supports all the PMBus oddities, converting the pmbus drivers to use regmap should be a separate patch set and not be tied together. Tnanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@xxxxxxxxxxxxxx http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
