On 07/24/2014 09:46 PM, Axel Lin wrote:
2014-07-25 12:29 GMT+08:00 Guenter Roeck <linux@xxxxxxxxxxxx>:
On 07/24/2014 08:14 PM, Axel Lin wrote:
Use of_match_ptr and proper #ifdef CONFIG_OF guard for of_device_id table.
Also makes of_pwm_fan_match const.
Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
The driver won't instantiate if OF is not configured.
You are right.
Then how about adding OF dependency to config SENSORS_PWM_FAN?
Then it won't compile with allmodconfig on x86. I prefer to be able
to compile it. So we would have to add COMPILE_TEST as secondary
dependency, and things would get more and more complex.
Not really sure if I want to go along that route.
Jean, any thoughts ?
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
