On 07/08/2014 05:27 PM, Axel Lin wrote:
2014-07-08 22:07 GMT+08:00 Guenter Roeck <linux@xxxxxxxxxxxx>:
On 06/28/2014 07:53 PM, Axel Lin wrote:
Use ATTRIBUTE_GROUPS macro and devm_hwmon_device_register_with_groups() to
simplify the code a bit.
Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
I'll need a Tested-by: to apply this patch.
Indeed. I think I'll try to CC more people when send v2.
---
Note, devm_hwmon_device_register_with_groups does not allow "-" in the
name
argument. So there is a change in 'name' attribute.
It was "da9052-hwmon", and now it's "da9052".
It might be worthwhile to send a separate patch to address this problem.
I know devm_hwmon_device_register_with_groups does not allow "-" in
the name argument,
but I don't know why.
So I'm wondering if current code which use "da9052-hwmon" in name
attribute causes any problem?
Yes, it does. Dashes are not allowed in hwmon name attributes.
See Documentation/hwmon-sysfs-interface. Dashes interfer with
name decoding in libsensors.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
